Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-12424] Add Retries to get #11176

Merged
merged 1 commit into from
Sep 23, 2024
Merged

[PM-12424] Add Retries to get #11176

merged 1 commit into from
Sep 23, 2024

Conversation

justindbaur
Copy link
Member

@justindbaur justindbaur commented Sep 20, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-12424

📔 Objective

Add retries to our get operation on chrome.storage.local. Even will completely empty state chrome.storage.local.get should return an {} empty object store, so if it was null we shouldn't treat that as a null value that we have stored. We should treat it like an error. This is a similar workaround (EFForg/privacybadger#2980) privacy badger has implemented.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details94641c47-2c8d-42bb-86eb-ffe28c430ccb

No New Or Fixed Issues Found

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 34.98%. Comparing base (ea025b9) to head (d84b08e).
Report is 13 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...platform/services/browser-local-storage.service.ts 0.00% 28 Missing ⚠️
apps/browser/src/background/main.background.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11176      +/-   ##
==========================================
- Coverage   34.99%   34.98%   -0.02%     
==========================================
  Files        2711     2711              
  Lines       84521    84548      +27     
  Branches    16063    16068       +5     
==========================================
  Hits        29579    29579              
- Misses      53971    53998      +27     
  Partials      971      971              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justindbaur justindbaur merged commit 073fd29 into main Sep 23, 2024
27 checks passed
@justindbaur justindbaur deleted the ps/pm-12424/add-get-retries branch September 23, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants