Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13876] improve credential generator options validation #11792

Closed
wants to merge 4 commits into from

Conversation

audreyality
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13876

📔 Objective

Improve the UX of credential generator validation logic.

Passphrase:

  • Validated fields that allow freehand editing (length, separator) only trigger generations when they're valid.
  • If a freehand field is invalid and loses focus, the field resets to its last-valid value and triggers generation.
  • If a checkbox field is adjusted and any field is invalid, the field resets to its last-valid value and triggers validation.
  • If a field is invalid and the user clicks the "generate" button, the field resets to its last-valid value and triggers validation.

Note: At present, this is only implemented for passphrase options. If the revised behavior is suitable, then it'll be ported to other credential settings panels.

📸 Screenshots

TBD

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@audreyality audreyality marked this pull request as ready for review October 30, 2024 16:28
@audreyality audreyality requested a review from a team as a code owner October 30, 2024 16:28
@audreyality audreyality added the hold do not merge, do not approve yet label Oct 30, 2024
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.54%. Comparing base (dd6def2) to head (4f76d0f).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11792   +/-   ##
=======================================
  Coverage   33.54%   33.54%           
=======================================
  Files        2810     2810           
  Lines       87329    87329           
  Branches    16658    16658           
=======================================
  Hits        29292    29292           
  Misses      55740    55740           
  Partials     2297     2297           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@audreyality audreyality marked this pull request as draft October 31, 2024 15:08
@audreyality
Copy link
Contributor Author

Superceded by #11816.

@audreyality audreyality closed this Nov 1, 2024
@audreyality audreyality deleted the tools/PM-13876/prevent-generate-until-valid branch November 7, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold do not merge, do not approve yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant