Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-281] A11y visual distinction required for page links #9878

Conversation

cagonzalezcs
Copy link
Contributor

@cagonzalezcs cagonzalezcs commented Jun 28, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-281

📔 Objective

This work goes through various anchor elements in the web application and updates those values to ensure they contain a bolded representation. It also adjusts help text for a variety of elements to provide better context to screen reader users.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Jun 28, 2024
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.05%. Comparing base (c13131a) to head (c5dca98).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9878   +/-   ##
=======================================
  Coverage   35.05%   35.05%           
=======================================
  Files        2711     2711           
  Lines       84577    84577           
  Branches    16070    16070           
=======================================
  Hits        29649    29649           
  Misses      53957    53957           
  Partials      971      971           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jun 28, 2024

Logo
Checkmarx One – Scan Summary & Details30ca25f5-4ca9-43be-af16-385f3e7c623c

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Client_Privacy_Violation /libs/tools/send/send-ui/src/send-form/components/options/send-options.component.ts: 51 Attack Vector
MEDIUM Client_Privacy_Violation /libs/tools/send/send-ui/src/send-form/components/options/send-options.component.ts: 51 Attack Vector

cagonzalezcs and others added 16 commits July 9, 2024 06:44
@cagonzalezcs cagonzalezcs force-pushed the autofill/pm-281-visual-distinction-required-for-login-page-links branch from 02937d9 to a4d87b5 Compare August 22, 2024 21:34
@cagonzalezcs cagonzalezcs removed the needs-qa Marks a PR as requiring QA approval label Sep 6, 2024
@cagonzalezcs cagonzalezcs marked this pull request as ready for review September 6, 2024 19:10
@cagonzalezcs cagonzalezcs requested review from a team as code owners September 6, 2024 19:10
@cagonzalezcs cagonzalezcs merged commit c276d5d into main Sep 20, 2024
35 checks passed
@cagonzalezcs cagonzalezcs deleted the autofill/pm-281-visual-distinction-required-for-login-page-links branch September 20, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants