-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-281] A11y visual distinction required for page links #9878
Merged
cagonzalezcs
merged 30 commits into
main
from
autofill/pm-281-visual-distinction-required-for-login-page-links
Sep 20, 2024
Merged
[PM-281] A11y visual distinction required for page links #9878
cagonzalezcs
merged 30 commits into
main
from
autofill/pm-281-visual-distinction-required-for-login-page-links
Sep 20, 2024
+112
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9878 +/- ##
=======================================
Coverage 35.05% 35.05%
=======================================
Files 2711 2711
Lines 84577 84577
Branches 16070 16070
=======================================
Hits 29649 29649
Misses 53957 53957
Partials 971 971 ☔ View full report in Codecov by Sentry. |
New Issues
|
…for-login-page-links
…for-login-page-links
…for-login-page-links
…for-login-page-links
…for-login-page-links
…for-login-page-links
…for-login-page-links
…for-login-page-links
…for-login-page-links
…for-login-page-links
…for-login-page-links
…for-login-page-links
…to aria labels for a variety of buttons
cagonzalezcs
force-pushed
the
autofill/pm-281-visual-distinction-required-for-login-page-links
branch
from
August 22, 2024 21:34
02937d9
to
a4d87b5
Compare
…for-login-page-links
…for-login-page-links
cagonzalezcs
requested review from
addisonbeck,
cturnbull-bitwarden and
ike-kottlowski
September 16, 2024 14:12
djsmith85
approved these changes
Sep 16, 2024
shane-melton
approved these changes
Sep 16, 2024
…for-login-page-links
addisonbeck
approved these changes
Sep 16, 2024
…for-login-page-links
…for-login-page-links
djsmith85
requested review from
ike-kottlowski and
cturnbull-bitwarden
and removed request for
cturnbull-bitwarden and
ike-kottlowski
September 18, 2024 21:03
…for-login-page-links
dani-garcia
approved these changes
Sep 19, 2024
cagonzalezcs
removed request for
justindbaur,
cd-bitwarden,
ike-kottlowski and
cturnbull-bitwarden
September 19, 2024 13:12
…for-login-page-links
ike-kottlowski
approved these changes
Sep 19, 2024
…for-login-page-links
…for-login-page-links
…for-login-page-links
jonashendrickx
approved these changes
Sep 20, 2024
cturnbull-bitwarden
approved these changes
Sep 20, 2024
cagonzalezcs
deleted the
autofill/pm-281-visual-distinction-required-for-login-page-links
branch
September 20, 2024 14:04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-281
📔 Objective
This work goes through various anchor elements in the web application and updates those values to ensure they contain a bolded representation. It also adjusts help text for a variety of elements to provide better context to screen reader users.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes