[PM-16998] Provide code style for Swift #517
Open
+157
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying contributing-docs with
|
| Latest commit: |
0b03126
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1653bd54.contributing-docs.pages.dev |
| Branch Preview URL: | https://pm-16998-swift-style.contributing-docs.pages.dev |
|
Great job, no security vulnerabilities found in this Pull Request |
fedemkr
reviewed
Jan 13, 2025
There was a problem hiding this comment.
Great job, really like this!
🤔 I was wondering if we should also put handful Xcode settings for Text Editing here as well as a tip. E.g. Enabling "Show reformatting guide" in "Editing" tab or in the same tab "Automatically trim trailing whitespace" + "Including whitespace-only lines".
Good call! Theoretically we could also put the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-16998
📔 Objective
This attempts to codify some of the code style conventions in the iOS codebase, and provides a place for us to document further decisions about code style.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes