Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-15176] Add newline to fix commit markdown formatting #120

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

SaintPatrck
Copy link
Contributor

๐ŸŽŸ๏ธ Tracking

PM-15176

๐Ÿ“” Objective

Replace app collapsable detail section with standard list. Add newline after summary node in metadata file changes list.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@SaintPatrck SaintPatrck requested a review from a team as a code owner December 11, 2024 22:54
@SaintPatrck SaintPatrck enabled auto-merge (squash) December 11, 2024 22:57
Copy link

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ f9de628f-af7e-49a5-8e9d-3f168c1d3421

No New Or Fixed Issues Found

@SaintPatrck SaintPatrck merged commit 768fb08 into main Dec 11, 2024
5 checks passed
@SaintPatrck SaintPatrck deleted the needs-more-newline branch December 11, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants