Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-11376] Improve automated commit message #29

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

SaintPatrck
Copy link
Contributor

🎟️ Tracking

📔 Objective

Refactor the update process to generate a detailed commit message.

The update script is now split into two separate scripts:

  • run_metascoop.sh: Builds and runs metascoop to download APKs and generate a commit message.
  • update_repo.sh: Performs git operations (commit, push, create PR) if changes are detected.

The commit message now includes a detailed summary of changes, including:

  • List of updated repositories.
  • For each repository:
    • List of updated releases.
    • For each release:
      • Release name and tag URL.
      • List of updated APKs.

Example

Updated apps from bitwarden/android

<details>
<summary>bitwarden/android</summary>

### [2024.8.1-beta (19099)](https://github.com/bitwarden/android/releases/tag/v2024.8.1)

- com.x8bit.bitwarden.beta-fdroid.apk

</details>

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

github-actions bot commented Sep 11, 2024

Logo
Checkmarx One – Scan Summary & Detailscf26de8b-2acd-4c74-b36e-7909618d9260

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /fdroid.yml: 45 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /fdroid.yml: 44

@SaintPatrck SaintPatrck force-pushed the PM-11376/improve-commit-msg branch 4 times, most recently from a0fd9d8 to 34e47b4 Compare September 11, 2024 21:43
@SaintPatrck SaintPatrck force-pushed the PM-11376/improve-commit-msg branch from 34e47b4 to 2868c38 Compare September 11, 2024 21:50
appClone := app
for _, repo := range reposList {
wg.Add(1)
go func(repo apps.Repo) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

n🧊

Copy link
Member

@vvolkgang vvolkgang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave it a first pass focused on the workflow changes and handling the commit message, looks great! Skipped some finer detail with the new multithreading approach in main.go but everything made sense and was easy* to follow, awesome job!

@SaintPatrck SaintPatrck marked this pull request as ready for review September 11, 2024 22:43
@SaintPatrck SaintPatrck requested a review from a team as a code owner September 11, 2024 22:43
@SaintPatrck SaintPatrck merged commit d0b9b3c into main Sep 11, 2024
4 of 5 checks passed
@SaintPatrck SaintPatrck deleted the PM-11376/improve-commit-msg branch September 11, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants