Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-11374][PM-11371] Repo cleanup and README update #32

Merged
merged 7 commits into from
Sep 13, 2024
Merged

Conversation

vvolkgang
Copy link
Member

@vvolkgang vvolkgang commented Sep 12, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-11374

📔 Objective

  1. README structure is now aligned with the existing instructions in https://mobileapp.bitwarden.com/fdroid/
  2. Removed unused code styling files and config
  3. Updates LICENSE

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vvolkgang vvolkgang requested a review from a team as a code owner September 12, 2024 23:17
Copy link

github-actions bot commented Sep 12, 2024

Logo
Checkmarx One – Scan Summary & Details75ef36c6-0f89-4aa7-a102-ffae07d0ac71

No New Or Fixed Issues Found

withinfocus
withinfocus previously approved these changes Sep 13, 2024
Copy link
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes make sense to me. Still a few other things to do that I listed out in chat though.

withinfocus
withinfocus previously approved these changes Sep 13, 2024
@vvolkgang vvolkgang enabled auto-merge (squash) September 13, 2024 17:39
Copy link
Contributor

@SaintPatrck SaintPatrck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One small correction.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Patrick Honkonen <[email protected]>
@vvolkgang vvolkgang merged commit 2a9e701 into main Sep 13, 2024
3 of 4 checks passed
@vvolkgang vvolkgang deleted the cleanup branch September 13, 2024 17:49
@vvolkgang vvolkgang changed the title [PM-11374] Repo cleanup and README update [PM-11374][PM-11371] Repo cleanup and README update Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants