Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13283] Update README links and add jekyll config #82

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Conversation

vvolkgang
Copy link
Member

@vvolkgang vvolkgang commented Oct 11, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13283

📔 Objective

  • Updates README links to the new dns and adds links to the top level images.
  • Testing adding a jekyll config so we can update the generated GH Page title and theme

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vvolkgang vvolkgang requested a review from a team as a code owner October 11, 2024 18:25
Copy link

github-actions bot commented Oct 11, 2024

Logo
Checkmarx One – Scan Summary & Details7bf3298a-a7a3-4f94-8be9-d241a528578f

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /fdroid.yml: 45 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

@vvolkgang vvolkgang changed the title [PM-13283] Update README links to the new DNS [PM-13283] Update README links and add jekyll config Oct 11, 2024
@vvolkgang vvolkgang enabled auto-merge (squash) October 11, 2024 18:37
@vvolkgang vvolkgang merged commit 9e5bbf3 into main Oct 11, 2024
5 checks passed
@vvolkgang vvolkgang deleted the improve-readme branch October 11, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants