Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update path for local sdk #1120

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Update path for local sdk #1120

merged 3 commits into from
Nov 12, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Nov 8, 2024

📔 Objective

We moved the sdk to a new repository, and are in the process of moving the language bindings.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton changed the title Update path to local sdk Update path for local sdk Nov 8, 2024
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Logo
Checkmarx One – Scan Summary & Detailsed0f912c-9c33-47a5-b7e9-5862278d659c

No New Or Fixed Issues Found

Copy link
Member

@fedemkr fedemkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This should be updated as well in project.yml given that local-idk.yml only applies when the environment variable LOCAL_SDK is true. Or were you meaning to only apply this to local one until the language bindings movement finishes?

@Hinton
Copy link
Member Author

Hinton commented Nov 11, 2024

@fedemkr project.yml references sdk-swift which is still correct.

@Hinton Hinton requested a review from fedemkr November 11, 2024 09:43
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.43%. Comparing base (c89573d) to head (3fb63a4).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1120   +/-   ##
=======================================
  Coverage   89.43%   89.43%           
=======================================
  Files         679      679           
  Lines       43114    43114           
=======================================
  Hits        38559    38559           
  Misses       4555     4555           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hinton Hinton merged commit e8a9381 into main Nov 12, 2024
9 checks passed
@Hinton Hinton deleted the local-sdk branch November 12, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants