[PM-14983] Support Optic ID and any future biometric authentication types #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # BitwardenShared/UI/Platform/Application/Support/Localizations/en.lproj/Localizable.strings
bunnyhero
requested review from
matt-livefront,
phil-livefront,
brant-livefront and
a team
as code owners
|
|
|
Thank you for your contribution! We've added this to our internal Community PR board for review. |
bunnyhero
changed the title
| @@ -129,6 +129,30 @@ class VaultUnlockSetupProcessorTests: BitwardenTestCase { | |||
| XCTAssertEqual(subject.state.unlockMethods, [.biometrics(.touchID), .pin]) | |||
| } | |||
|
|
|||
| /// `perform(_:)` with `.loadData` fetches the biometrics unlock status for a device with Touch ID. | |||
There was a problem hiding this comment.
🎨 Can you please update these comments to indicate Optic ID and a generic biometrics fallback?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
📔 Objective
Support Optic ID and any future biometric authentication types.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes