Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-15904] Implement Credential Exchange Import flow #1223

Merged
merged 10 commits into from
Jan 6, 2025

Merge branch 'main' into PM-14800/impl-cxp-import-flow

9e3b678
Select commit
Loading
Failed to load commit list.
Merged

[PM-15904] Implement Credential Exchange Import flow #1223

Merge branch 'main' into PM-14800/impl-cxp-import-flow
9e3b678
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 27, 2024 in 0s

89.59% (+0.11%) compared to 43e1883

View this Pull Request on Codecov

89.59% (+0.11%) compared to 43e1883

Details

Codecov Report

Attention: Patch coverage is 92.48705% with 29 lines in your changes missing coverage. Please review.

Project coverage is 89.59%. Comparing base (43e1883) to head (9e3b678).

Files with missing lines Patch % Lines
...denShared/UI/Tools/ImportCXP/ImportCXPModule.swift 0.00% 6 Missing ⚠️
...nShared/UI/Platform/Application/AppProcessor.swift 66.66% 5 Missing ⚠️
...Tools/ImportCXP/ImportCXP/ImportCXPProcessor.swift 87.80% 5 Missing ⚠️
...twardenShared/Core/Platform/Utilities/AnyKey.swift 50.00% 4 Missing ⚠️
...e/Tools/Repositories/ImportCiphersRepository.swift 66.66% 3 Missing ⚠️
...ore/Tools/Utilities/CredentialManagerFactory.swift 50.00% 3 Missing ⚠️
...d/UI/Tools/ImportCXP/ImportCXP/ImportCXPView.swift 97.43% 2 Missing ⚠️
...nShared/Core/Platform/Services/ClientService.swift 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1223      +/-   ##
==========================================
+ Coverage   89.47%   89.59%   +0.11%     
==========================================
  Files         700      709       +9     
  Lines       44733    45079     +346     
==========================================
+ Hits        40026    40387     +361     
+ Misses       4707     4692      -15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov