Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-15634] Add intermediate Export settings view #1227

Open
wants to merge 4 commits into
base: PM-14800/impl-cxp-import-flow
Choose a base branch
from

Conversation

fedemkr
Copy link
Member

@fedemkr fedemkr commented Dec 23, 2024

🎟️ Tracking

PM-15634

📔 Objective

Add intermediate Export settings view so that the user can choose whether to export to a file or using the Credential Exchange flow.

⚠️ Depends on #1223, so it should be merged after it.

Notes

The old "Export vault" view files were moved to another folder, so now we have this structure:

  • ExportVault
    • Export
      • ExportSettingsView
    • ExportVaultCXF
      • TODO in next PR
    • ExportVaultToFile
      • ExportVaultView

📸 Screenshots

Export.intermediate.view.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

…when Credential Exchange flag is enabled so the user can decide whether the export to a file or using the Credential Exchange flow.
Copy link
Contributor

github-actions bot commented Dec 23, 2024

Logo
Checkmarx One – Scan Summary & Details066adab4-b25a-4d5d-8a92-d24b2be3b3c2

No New Or Fixed Issues Found

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (PM-14800/impl-cxp-import-flow@0bff554). Learn more about missing BASE report.

Additional details and impacted files
@@                       Coverage Diff                        @@
##             PM-14800/impl-cxp-import-flow    #1227   +/-   ##
================================================================
  Coverage                                 ?   89.60%           
================================================================
  Files                                    ?      711           
  Lines                                    ?    45137           
  Branches                                 ?        0           
================================================================
  Hits                                     ?    40445           
  Misses                                   ?     4692           
  Partials                                 ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant