Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-9483] Fix added Attachment from the Edit Cipher Screen on mobile apps can't be retrieved #3344

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

LRNcardozoWDF
Copy link
Member

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Ensure attachments that are added on edit cipher screen can be retrieved.

Code changes

  • src/Core/Services/CipherService.cs: Although attachments added on edit cipher screen are updated on server, that state isn't applied to the cipher in memory. This ensures that the current cipher has the updated attachments.

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@LRNcardozoWDF LRNcardozoWDF requested a review from a team as a code owner July 5, 2024 15:47
@LRNcardozoWDF LRNcardozoWDF merged commit b81ce44 into main Jul 8, 2024
11 checks passed
@LRNcardozoWDF LRNcardozoWDF deleted the vault/pm-9483 branch July 8, 2024 14:27
@LRNcardozoWDF LRNcardozoWDF restored the vault/pm-9483 branch July 8, 2024 15:55
@LRNcardozoWDF LRNcardozoWDF deleted the vault/pm-9483 branch July 8, 2024 15:57
LRNcardozoWDF added a commit that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants