Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Passwordless.AspNetCore registration overloads that support IConfiguration properly #146

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

Tyrrrz
Copy link
Contributor

@Tyrrrz Tyrrrz commented Aug 5, 2024

This PR fixes an issue where, when registering the Passwordless Identity integration, the core options (PasswordlessOptions) were not initialized with reload-tracking, due to the fact that the SDK was registered with services.AddPasswordlessSdk(_ => {}). Even though we forwarded the options by re-registering them inside the Identity integration, this did not forward the corresponding reload token.

I also added a few tests for configuration-related scenarios, although properly e2e testing configuration routing is quite challenging.

@Tyrrrz Tyrrrz requested a review from a team as a code owner August 5, 2024 19:50
@Tyrrrz Tyrrrz enabled auto-merge (squash) August 5, 2024 19:53
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 34 lines in your changes missing coverage. Please review.

Project coverage is 59.82%. Comparing base (540def1) to head (f254967).

Files Patch % Lines
...sswordless.AspNetCore/IdentityBuilderExtensions.cs 43.10% 33 Missing ⚠️
src/Passwordless/ServiceCollectionExtensions.cs 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
- Coverage   61.39%   59.82%   -1.58%     
==========================================
  Files          43       43              
  Lines         658      687      +29     
  Branches       56       56              
==========================================
+ Hits          404      411       +7     
- Misses        250      272      +22     
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tyrrrz Tyrrrz merged commit 04adada into main Aug 6, 2024
7 checks passed
@Tyrrrz Tyrrrz deleted the better-options branch August 6, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants