Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve licensing language #10

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Improve licensing language #10

merged 3 commits into from
Oct 24, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Oct 24, 2024

📔 Objective

Improve language around licensing for most crates to be GPL or Bitwarden SDK License.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Oct 24, 2024

Logo
Checkmarx One – Scan Summary & Details081264b6-3e9e-4bb2-938a-da05b6ce6c2c

No New Or Fixed Issues Found

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.84%. Comparing base (75ad38e) to head (93ef3b2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #10   +/-   ##
=======================================
  Coverage   62.84%   62.84%           
=======================================
  Files         179      179           
  Lines       12688    12688           
=======================================
  Hits         7974     7974           
  Misses       4714     4714           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hinton Hinton marked this pull request as ready for review October 24, 2024 17:23
@Hinton Hinton changed the title Change license to dual license for some crates Improve licensing language Oct 24, 2024
@Hinton Hinton requested review from kspearrin and MGibson1 October 24, 2024 17:24
@Hinton Hinton merged commit db648d7 into main Oct 24, 2024
40 checks passed
@Hinton Hinton deleted the license branch October 24, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants