Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge] crypto-next tests #21

Closed
wants to merge 11 commits into from
Closed

Conversation

quexten
Copy link
Contributor

@quexten quexten commented Nov 1, 2024

🎟️ Tracking

📔 Objective

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 200 lines in your changes missing coverage. Please review.

Project coverage is 61.85%. Comparing base (1d89786) to head (6690332).
Report is 44 commits behind head on main.

Files with missing lines Patch % Lines
crates/bitwarden-wasm-internal/src/crypto.rs 0.00% 81 Missing ⚠️
crates/bitwarden-crypto/src/chacha20.rs 0.00% 60 Missing ⚠️
crates/bitwarden-crypto/src/ed25519.rs 0.00% 23 Missing ⚠️
crates/bitwarden-crypto/src/xwing.rs 0.00% 22 Missing ⚠️
crates/bitwarden-crypto/src/x25519.rs 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
- Coverage   62.85%   61.85%   -1.00%     
==========================================
  Files         179      183       +4     
  Lines       12688    12888     +200     
==========================================
- Hits         7975     7972       -3     
- Misses       4713     4916     +203     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 11, 2024

Logo
Checkmarx One – Scan Summary & Detailsfcf488c8-822e-4d63-8192-4da7643006d0

New Issues

Severity Issue Source File / Package Checkmarx Insight
LOW Unpinned Actions Full Length Commit SHA /publish-internal.yml: 61 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /publish-internal.yml: 67 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
LOW Unpinned Actions Full Length Commit SHA /build-wasm-internal.yml: 91
LOW Unpinned Actions Full Length Commit SHA /publish-wasm-internal.yml: 74
LOW Unpinned Actions Full Length Commit SHA /publish-wasm-internal.yml: 80

@quexten quexten changed the title [Do not merge] Symmetric-crypto-next tests [Do not merge] crypto-next tests Nov 11, 2024
@quexten quexten closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant