Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13058] Remove waiting for tests to pass before publishing #22

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Nov 4, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13058

📔 Objective

Disabled the check for tests to pass since it's not working correctly. We can revisit this at a later point.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.85%. Comparing base (8afb703) to head (bf6cbbd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #22   +/-   ##
=======================================
  Coverage   62.85%   62.85%           
=======================================
  Files         179      179           
  Lines       12688    12688           
=======================================
  Hits         7975     7975           
  Misses       4713     4713           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hinton Hinton changed the title Switch to using sha ref Remove waiting for tests to pass before publishing Nov 4, 2024
@Hinton Hinton changed the title Remove waiting for tests to pass before publishing [PM-13058] Remove waiting for tests to pass before publishing Nov 4, 2024
Copy link
Contributor

@coroiu coroiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be tested on PRs anyways 🤷

@Hinton Hinton merged commit e2946ce into main Nov 4, 2024
43 checks passed
@Hinton Hinton deleted the fix-wait-check branch November 4, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants