Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14808] Add uris to ListView #29

Merged
merged 3 commits into from
Nov 11, 2024
Merged

[PM-14808] Add uris to ListView #29

merged 3 commits into from
Nov 11, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Nov 11, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14808

📔 Objective

Adds the login URIs to CipherListView to make it useable for autofill.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Nov 11, 2024

Logo
Checkmarx One – Scan Summary & Details1c01a5c1-6610-4205-9f5d-5f2abed89bac

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /publish-wasm-internal.yml: 80 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-wasm-internal.yml: 91 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /publish-wasm-internal.yml: 74 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-swift.yml: 95 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /release-swift.yml: 136 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /release-swift.yml: 73 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /publish-rust-crates.yml: 76 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 44 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

@Hinton Hinton force-pushed the add-uris-login-list branch from b5d327c to cc0ddc9 Compare November 11, 2024 15:44
@Hinton Hinton marked this pull request as ready for review November 11, 2024 15:46
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.

Project coverage is 62.87%. Comparing base (2d677e8) to head (cdf4c19).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/bitwarden-vault/src/cipher/login.rs 70.00% 3 Missing ⚠️
crates/bitwarden-vault/src/cipher/cipher.rs 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   62.85%   62.87%   +0.01%     
==========================================
  Files         179      179              
  Lines       12688    12696       +8     
==========================================
+ Hits         7975     7982       +7     
- Misses       4713     4714       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hinton Hinton changed the title Add uris to ListView [PM-14808] Add uris to ListView Nov 11, 2024
@Hinton Hinton requested a review from dani-garcia November 11, 2024 16:01
dani-garcia
dani-garcia previously approved these changes Nov 11, 2024
crates/bitwarden-vault/src/cipher/login.rs Show resolved Hide resolved
…s-login-list

# Conflicts:
#	crates/bitwarden-vault/src/cipher/cipher.rs
#	crates/bitwarden-vault/src/totp.rs
@Hinton Hinton merged commit a5f98db into main Nov 11, 2024
39 checks passed
@Hinton Hinton deleted the add-uris-login-list branch November 11, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants