Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13660] implement catchable non generic error types #31

Merged
merged 54 commits into from
Nov 19, 2024

fix: doctest

6347bae
Select commit
Loading
Failed to load commit list.
Merged

[PM-13660] implement catchable non generic error types #31

fix: doctest
6347bae
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 18, 2024 in 0s

63.39% (+0.51%) compared to 1b10d83

View this Pull Request on Codecov

63.39% (+0.51%) compared to 1b10d83

Details

Codecov Report

Attention: Patch coverage is 87.20000% with 32 lines in your changes missing coverage. Please review.

Project coverage is 63.39%. Comparing base (1b10d83) to head (6347bae).

Files with missing lines Patch % Lines
crates/bitwarden-wasm-internal/src/crypto.rs 0.00% 10 Missing ⚠️
crates/bitwarden-wasm-internal/src/client.rs 0.00% 6 Missing ⚠️
crates/bitwarden-error-macro/src/attribute.rs 89.18% 4 Missing ⚠️
crates/bitwarden-error-macro/src/flat/attribute.rs 97.05% 3 Missing ⚠️
crates/bitwarden-error-macro/src/full/attribute.rs 88.00% 3 Missing ⚠️
crates/bitwarden-error-macro/src/args.rs 0.00% 2 Missing ⚠️
...rates/bitwarden-wasm-internal/src/vault/folders.rs 0.00% 2 Missing ⚠️
...s/bitwarden-core/src/client/encryption_settings.rs 0.00% 1 Missing ⚠️
crates/bitwarden-core/src/error.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   62.87%   63.39%   +0.51%     
==========================================
  Files         179      184       +5     
  Lines       12699    12935     +236     
==========================================
+ Hits         7985     8200     +215     
- Misses       4714     4735      +21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov