-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PM-16261 move ImportCiphersAsync to the tools team #5245
PM-16261 move ImportCiphersAsync to the tools team #5245
Conversation
…s using CQRS design pattern
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5245 +/- ##
==========================================
+ Coverage 44.02% 44.10% +0.07%
==========================================
Files 1476 1478 +2
Lines 68291 68316 +25
Branches 6175 6175
==========================================
+ Hits 30065 30128 +63
+ Misses 36919 36877 -42
- Partials 1307 1311 +4 ☔ View full report in Codecov by Sentry. |
New Issues (1)Checkmarx found the following issues in this Pull Request
Fixed Issues (4)Great job! The following issues were fixed in this Pull Request
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prograhamming: Great work! Changes are looking good overall. Just some small things I noticed
src/Core/Tools/ImportFeatures/Interfaces/IImportCiphersCommand.cs
Outdated
Show resolved
Hide resolved
src/Core/Tools/ImportFeatures/Interfaces/IImportCiphersCommand.cs
Outdated
Show resolved
Hide resolved
…d-into-tools-team
🎟️ Tracking
https://bitwarden.atlassian.net/jira/software/c/projects/BW/boards/92?selectedIssue=PM-16261
📔 Objective
Currently the ImportCiphersAsync methods located in the CipherService are used by the ImportCiphersController. The import process is owned by Tools but the file-structure does not reflect this, which requires reviews from Vault-team anytime we need to adjust something.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes