Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-16261 move ImportCiphersAsync to the tools team #5245

Conversation

prograhamming
Copy link
Contributor

@prograhamming prograhamming commented Jan 9, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/jira/software/c/projects/BW/boards/92?selectedIssue=PM-16261

📔 Objective

Currently the ImportCiphersAsync methods located in the CipherService are used by the ImportCiphersController. The import process is owned by Tools but the file-structure does not reflect this, which requires reviews from Vault-team anytime we need to adjust something.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@prograhamming prograhamming requested review from a team as code owners January 9, 2025 22:08
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 81.88976% with 23 lines in your changes missing coverage. Please review.

Project coverage is 44.10%. Comparing base (04402c1) to head (1689d90).
Report is 33 commits behind head on main.

Files with missing lines Patch % Lines
.../Core/Tools/ImportFeatures/ImportCiphersCommand.cs 83.89% 12 Missing and 7 partials ⚠️
...c/Api/Tools/Controllers/ImportCiphersController.cs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5245      +/-   ##
==========================================
+ Coverage   44.02%   44.10%   +0.07%     
==========================================
  Files        1476     1478       +2     
  Lines       68291    68316      +25     
  Branches     6175     6175              
==========================================
+ Hits        30065    30128      +63     
+ Misses      36919    36877      -42     
- Partials     1307     1311       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Logo
Checkmarx One – Scan Summary & Detailsbbcae1aa-bee3-48b7-8ee6-65fabc72d445

New Issues (1)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
LOW Missing_CSP_Header /src/Core/MailTemplates/Handlebars/AdminConsole/DomainClaimedByOrganization.html.hbs: 7
detailsA Content Security Policy is not explicitly defined within the web-application.
Attack Vector
Fixed Issues (4)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/PoliciesController.cs: 46
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/PoliciesController.cs: 65
MEDIUM CSRF /src/Identity/Controllers/AccountsController.cs: 119
MEDIUM CSRF /src/Api/Tools/Controllers/SendsController.cs: 147

nick-livefront
nick-livefront previously approved these changes Jan 10, 2025
Copy link
Contributor

@djsmith85 djsmith85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prograhamming: Great work! Changes are looking good overall. Just some small things I noticed

@prograhamming prograhamming changed the title PM-16261 move ImportCiphersAsync to the tools team and create service… PM-16261 move ImportCiphersAsync to the tools team Jan 13, 2025
@djsmith85 djsmith85 self-requested a review January 13, 2025 17:37
@prograhamming prograhamming merged commit 99a1dbb into main Jan 24, 2025
53 checks passed
@prograhamming prograhamming deleted the tools/pm-16261/move-importCiphersAsync-method-into-tools-team branch January 24, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants