-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SM-1020] Update to node 20 and latest GitHub action template standards #34
Merged
+26,049
−6,213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Issues
Fixed Issues
|
tangowithfoxtrot
approved these changes
Nov 29, 2023
Hinton
approved these changes
Nov 30, 2023
michalchecinski
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
The purpose of this PR is to update the sm-action to node 20 and upgrade all dependencies.
This PR also updates to the latest recommended pattern of GitHub's typescript action template which was recently updated to node 20.
A successful run can be found here.
An intentionally failed run where an incorrect secret ID was entered can be found here.
Code changes
.github/workflows/build-test.yml:
Updated workflow to use node 20.
.github/workflows/check-dist.yml:
Updated workflow to use node 20 and updating with the typescript action templates latest dist compare.
.github/workflows/lint.yml:
Updated workflow to use node 20.
.github/workflows/qa-run.yml:
Updating the QA run to run on multiple OS to increase coverage.
.github/workflows/release.yml:
Formatting upgrades added a missing newline to this workflow.
README.md:
Updated to new command structure.
tests/index.test.ts:
Added unit tests for index.ts
tests/main.test.ts:
Added simple unit tests for main.ts
tests/parser.test.ts:
Formatting upgrades
action.yml:
Updated action to use node 20 and moved branding under author to conform to the template.
dist/index.js
Newly ncc bundled action code.
dist/licenses.txt
License updates because of dependency upgrades.
dist/index.js.map
dist/sourcemap-register.js
The template recommends not including source map generation for the ncc command which removes these files.
package-lock.json
Changed from dependency upgrades.
package.json
Updated all dependencies.
Pinned all dependencies.
Added engines to indicated needing node 20.
The recommendation is now to target the ts entry point file directly in the ncc build.
ncc build src/index.ts
.With this we no longer need to run
tsc
and have a lib folder.src/index.ts
Conforming to the template of having an index.ts that calls main.
src/main.ts
Exporting the run function so it can be called in index.ts
src/parser.ts
Formatting upgrades
tsconfig.json
Conforming to the template updates for node 20.
From my understanding, the added settings are to enable using typescript 5.3.2.