Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: optional immersive rendering in visionOS #3335

Merged
merged 2 commits into from
Aug 10, 2024
Merged

feat: optional immersive rendering in visionOS #3335

merged 2 commits into from
Aug 10, 2024

Conversation

simsaens
Copy link
Contributor

@simsaens simsaens commented Aug 4, 2024 •
edited
Loading

This uses the type of nwh to determine whether to implement immersive rendering through Compositor Services, or fall back to standard Metal rendering with CAMetalLayer

Opening this up for review as @okwasniewski has kindly begun trying out the changes

okwasniewski
okwasniewski reviewed Aug 7, 2024
View reviewed changes
Copy link
Contributor

@okwasniewski okwasniewski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've integrated the changes with Babylon Native renderer and everything works as expected!

ScreenRecording_08-07-2024.10-52-17_1.MP4

Note: I still need to check runtime switching to immersive mode! I will let you know if this works propery

@simsaens simsaens marked this pull request as ready for review August 7, 2024 11:35
@bkaradzic bkaradzic merged commit 3f3d3b4 into bkaradzic:master Aug 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okwasniewski okwasniewski okwasniewski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simsaens @okwasniewski @bkaradzic