Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub workflows for real GitHub #38

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

stefanb2
Copy link
Contributor

@stefanb2 stefanb2 commented Oct 26, 2023

There is a difference between act-cli and real GitHub environment: context variables contain paths that are not valid inside the runner environment.

Also add git to dependencies to make sure we use a git checkout instead of a tarball.

  • add ca-certificates & git packages to dependencies
  • move checkout step after dependency installation
  • replace ${{ github.workspace }} with ${GITHUB_WORKSPACE} inside steps
  • replace ${{ runner.temp }} with ${RUNNER_TEMP} inside steps

@stefanb2 stefanb2 force-pushed the topic-fix-github-workflows-for-github branch 3 times, most recently from 771fbf7 to 6b0c0c4 Compare October 26, 2023 09:09
@stefanb2
Copy link
Contributor Author

GitHub guys, WTF?

GITHUB_WORKSPACE=/__w/qMasterPassword/qMasterPassword
RUNNER_WORKSPACE=/__w/qMasterPassword
....
PWD1=/__w/qMasterPassword/qMasterPassword
PWD2=/__w/qMasterPassword/qMasterPassword

# echo "WORKSPACE=${{ github.workspace }}"
WORKSPACE=/home/runner/work/qMasterPassword/qMasterPassword
ls: cannot access '/home/runner/work/qMasterPassword/qMasterPassword': No such file or directory
ls: cannot access '/home/runner/work/qMasterPassword/qMasterPassword/data/icons/': No such file or directory

A documented context value that doesn't work inside the step?

@stefanb2 stefanb2 force-pushed the topic-fix-github-workflows-for-github branch 2 times, most recently from 8922a2d to 476abf7 Compare October 26, 2023 09:34
@stefanb2 stefanb2 marked this pull request as ready for review October 26, 2023 09:40
@stefanb2
Copy link
Contributor Author

@bkueng ready for merging. Let's see if AppImage artifacts appear on the project page after merging this.

There is a difference between act-cli and real GitHub environment:
context variables contain paths that are not valid inside the runner
environment.

Also add git to dependencies to make sure we use a git checkout instead
of a tarball.

- add ca-certificates & git packages to dependencies
- move checkout step after dependency installation
- replace ${{ github.workspace }} with ${GITHUB_WORKSPACE} inside steps
- replace ${{ runner.temp }} with ${RUNNER_TEMP} inside steps
@stefanb2 stefanb2 force-pushed the topic-fix-github-workflows-for-github branch from 476abf7 to 693c6f4 Compare October 26, 2023 09:45
@bkueng bkueng merged commit bacd14a into bkueng:main Oct 26, 2023
14 checks passed
@stefanb2 stefanb2 deleted the topic-fix-github-workflows-for-github branch October 27, 2023 05:51
@stefanb2
Copy link
Contributor Author

The uploaded artifacts are hiding on the PR merge build summary page.

Only problem is that GitHub creates a .zip for the download, which is (a) unnecessary as the AppImage is already compressed and (b) does not set the execute flag on the AppImage file, i.e. the user has to manually set after unzipping the contents. This seems to be long-standing issue with artifact up/download, which hopefully will be solved at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants