Fix Windows build & add CI #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- matrix: build against Qt 5 & 6
… (const char*) fixes this error: D:\a\qMasterPassword\qMasterPassword\src\keypress_windows.cpp(99,5): error C2664: 'void CKeyboardSimulator::TextEntry(LPCTSTR)': cannot convert argument 1 from 'const _Elem *' to 'LPCTSTR' [D:\a\_temp\build\qMasterPassword.vcxproj]
_WIN32 is defined by the compiler whereas WIN32 by the SDK.
ERROR was conflicting with a macro on Windows.
|
@bkueng I of course can't push to this branch. So I fast-forwarded #37 to the HEAD of this branch and added a commit to address the compiler / linker warnings. If I understand the compiler warnings correctly, the resulting code wouldn't have worked. I marked #37 now as ready for review. After this is merged we can work on additional build steps for Windows, i.e. installation, packaging and uploading of the build artifact. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of #37.
@stefanb2 this fixes the Windows build and adds the required dependencies.