Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: optimize windows build #42

Closed
wants to merge 1 commit into from

Conversation

stefanb2
Copy link
Contributor

@stefanb2 stefanb2 commented Nov 4, 2023

Instead of building scrypt-windows from scratch, use binary artifacts created by another repo.

@stefanb2 stefanb2 force-pushed the topic-optimize-windows-build branch 2 times, most recently from a9afd70 to bc2537e Compare November 4, 2023 21:01
@stefanb2
Copy link
Contributor Author

stefanb2 commented Nov 4, 2023

@bkueng this would cut build time for the Windows workflows by about half.

@bkueng
Copy link
Owner

bkueng commented Nov 5, 2023

I was wondering if it's worth doing that, 5 min isn't terrible yet (I'm used to waiting much more on other projects).
But given it's that simple, we can certainly do that.
Another option would be to use ccache if there's a Windows-equivalent.

Instead of building scrypt-windows from scratch, use binary artifacts
created by another repo.
@stefanb2
Copy link
Contributor Author

stefanb2 commented Nov 6, 2023

In my earlier life I got paid to be a SW Build Architect. Hence I hate slow, inefficient & unreliable SW builds.

Can you please create your own fork of barrysteyn/scrypt-windows and cherry-pick the GitHub action commit ontop of it? I only forked it, so I could create the commit, but I have no intention of maintaining the repo, as I don't have any Windows machines.

@stefanb2
Copy link
Contributor Author

stefanb2 commented Nov 6, 2023

Another option would be to use ccache if there's a Windows-equivalent.

Another option would be to add the few source code files from Tarsnap/scrypt under 3rdparty/ (in my understanding the real upstream source for scrypt code) to get the crypto_scrypt() function for Windows build. That would also mean that we have the latest version of it.

@bkueng
Copy link
Owner

bkueng commented Nov 6, 2023

Another option would be to add the few source code files from Tarsnap/scrypt under 3rdparty/ (in my understanding the real upstream source for scrypt code) to get the crypto_scrypt() function for Windows build. That would also mean that we have the latest version of it.

That is my preferred approach, possibly as a submodule. But I haven't seen Windows as explicitly supported. It might be easy to get it to work. Do you want to look into that?

@stefanb2
Copy link
Contributor Author

stefanb2 commented Nov 7, 2023

Sure, I'll take a stab at it.

@stefanb2
Copy link
Contributor Author

stefanb2 commented Nov 8, 2023

Replaced by #43.

@stefanb2 stefanb2 closed this Nov 8, 2023
@stefanb2 stefanb2 deleted the topic-optimize-windows-build branch November 8, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants