-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: optimize windows build #42
Conversation
a9afd70
to
bc2537e
Compare
@bkueng this would cut build time for the Windows workflows by about half. |
I was wondering if it's worth doing that, 5 min isn't terrible yet (I'm used to waiting much more on other projects). |
Instead of building scrypt-windows from scratch, use binary artifacts created by another repo.
In my earlier life I got paid to be a SW Build Architect. Hence I hate slow, inefficient & unreliable SW builds. Can you please create your own fork of barrysteyn/scrypt-windows and cherry-pick the GitHub action commit ontop of it? I only forked it, so I could create the commit, but I have no intention of maintaining the repo, as I don't have any Windows machines. |
Another option would be to add the few source code files from Tarsnap/scrypt under 3rdparty/ (in my understanding the real upstream source for scrypt code) to get the |
That is my preferred approach, possibly as a submodule. But I haven't seen Windows as explicitly supported. It might be easy to get it to work. Do you want to look into that? |
Sure, I'll take a stab at it. |
bc2537e
to
eef4f79
Compare
Replaced by #43. |
Instead of building scrypt-windows from scratch, use binary artifacts created by another repo.