pivot and var_names incompatible in VariantFrequencies
#39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously you could specify both `pivot` and `var_names` when instantiating `VariantFrequencies`. But if this was done, the value of `pivot` was silently ignored in favor of making the pivot variant the last name in `var_names`. This pull request fixes this misleading behavior by making those parameters mutually exclusive, and raising an error if the user tries to set both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously you could specify both
pivotandvar_nameswhen instantiatingVariantFrequencies. But if this was done, the value ofpivotwas silently ignored in favor of making the pivot variant the last name invar_names.This pull request fixes this misleading behavior by making those parameters mutually exclusive, and raising an error if the user tries to set both.