Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore page change cache error, and fix styling for 1.36 #100

Merged
merged 5 commits into from
Jun 25, 2024
Merged

Conversation

blackary
Copy link
Owner

@blackary blackary commented Jun 25, 2024

Fixes #99

Note that the error fix is just a band-aid, and might undo some previous work to correctly cache pages.

I am intending to release a new version of st-pages that is a tiny wrapper around the new st.navigation functionality in streamlit 1.36.0

[NOTE]

The test suite is failing, and needs some re-working, but since I'm intending to deprecate a lot of the code in the repo, I'm contenting myself with a manual deploy and manual check at https://accmcdwztzfkymkszxhnrq.streamlit.app/

@blackary blackary merged commit 1afb267 into main Jun 25, 2024
6 of 9 checks passed
@blackary blackary deleted the support-1.36 branch June 25, 2024 16:54
@andrew-weisman
Copy link

Hi @blackary, thanks for such a great package!

Regarding your stated plans, my one request if you wouldn't mind would be that you make sure that multiprocessing can run successfully on any of the pages. I know multiprocessing requires an if __name__ == '__main__' block. st_pages currently supports this. The new Streamlit functionality may support it by way of pages as functions but I just wanted to make sure everything was compatible.

Thanks so much @blackary!

@andrew-weisman
Copy link

@blackary FYI, here is a complete example that seems to work with multiprocessing appropriately, using the functions method in the new multipage FYI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Streamlit 1.36.0 breaks functionality
2 participants