-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue caused by new script cache in 1.23.1 #49
Conversation
Hi @blackary any chance you can look at this? |
@mfriedy I had trouble getting the fix to work without adding a tiny sleep. After that it seemed to work fine. Now making sure it still works with different versions. |
I can get the tests to pass locally, but am having trouble getting them to pass on github actions so far :/ |
That's really weird re the sleep, no idea. Is it something to do with accessing the runtime directly? |
…pages into streamlit1231_compat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THANK YOU so much for this improvement -- so sorry it took so long to get everything passing
Fixes #46
@blackary - I am not sure how correct it is to directly interact with the runtime like this. But it seems to fix the issue :)