Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-implement get_conn as a plain async fn #285

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Re-implement get_conn as a plain async fn #285

wants to merge 2 commits into from

Commits on Jan 10, 2024

  1. Hide GetConn 

    This makes the future implementation private. This is a braking
change, but:

* It is unlikely anyone was using GetConn directly instead of just
  awaiting it.

* This opens the way for replacing the manual implementation with an
  async fn.
    @espindola
    espindola committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    53270c0 View commit details
    Browse the repository at this point in the history

  2. Re-implement get_conn as a plain async fn 

    Avoiding the manual implementation of Future makes this code quite a
bit simpler IMHO.
    @espindola
    espindola committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    ad0d425 View commit details
    Browse the repository at this point in the history