Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master #37

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

master #37

wants to merge 3 commits into from

Conversation

thedarkmen4you
Copy link

No description provided.

Auto repaint swing components
Fix issue blackears#36
@blackears
Copy link
Owner

This looks like a big change. Could you describe in more detail what the issue is that this is supposed to solve?

Also, your edits to SVGDiagram.java are replacing a lot of existing lines with identical lines. You need to fix this so that only the changes you made appear in the pull request.

Copy link
Author

@thedarkmen4you thedarkmen4you left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit solves issue #37 for the class "XMLParseUtil.java". Another change is about synchronizing all animated svg from the application, for this change I didn't made an issue.

@blackears
Copy link
Owner

blackears commented Jan 7, 2019

There is still the problem that you are overwriting SVGDiagram.java and XMLParseUtil.java with what appears to be identical copies of these files. You need to change your commit so that only changes you made are submitted. Also, how are your new files used if there is nothing in the main code that calls them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants