Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[youtube] Match JSON in alert regex #163

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ZenulAbidin
Copy link
Contributor

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

yt-alert-message div has moved to "alert" JSON key, so this PR adjusts the regex to match that.

I tested this change by dumping page into a file (such as this one) and manually editing the alerts[alertRenderer][text][run][text] subkey for each condition. Then you'd set a breakpoint at line 2894 or somewhere near that and load page using

with open('/tmp/yt-alert-message-div.txt') as ff:
    page = ff.read()

These steps allow you to reproduce these tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant