Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tiktok download #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix tiktok download #20

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bbc0bb
fix tiktok download
GreyAlien502 Oct 26, 2020
61e76c1
simplify second page fetch
GreyAlien502 Oct 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions youtube_dlc/extractor/tiktok.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,8 @@ class TikTokIE(TikTokBaseIE):
def _real_extract(self, url):
video_id = self._match_id(url)

# If we only call once, we get a 403 when downlaoding the video.
self._download_webpage(url, video_id)
webpage = self._download_webpage(url, video_id, note='Downloading video webpage')
Comment on lines +137 to 138
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this so that it won't download the webpage twice if not necessary. You can check the result and implement some try again but only once if response isn't satisfying.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If anyone can provide a way of determining if the response is satisfying, i can add such a check.
I don't see any meaningful difference between the first and second responses i receive.
Is there a specific reason why you think such a check would be possible?

json_string = self._search_regex(
r'id=\"__NEXT_DATA__\"\s+type=\"application\/json\"\s*[^>]+>\s*(?P<json_string_ld>[^<]+)',
Expand Down