Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✔️ added preload feature #109

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Shadow60539
Copy link

@Shadow60539 Shadow60539 commented May 29, 2021

resolves #108

Concept Followed 👇

concept

@blackmann
Copy link
Owner

Great work, I'll review this shortly

@blackmann
Copy link
Owner

Hello @Shadow60539 I have tried to use this PR with the storyexample project... But when I get to the 4th story item (back from the 5th), I am unable to go to the previous (3rd) story item or next (5th) item. I'm just stuck on the 4th.

Looking through the code, I saw some _lock handle... do you think it's necessary to lock the experience while preloading occurs?

@Shadow60539
Copy link
Author

Hello @blackmann

🔒 I wasn't able to come up with any other way other than locking the user.
Initially, I thought of displaying the same loading widget when the next or previous video is not initialized yet.
However, I used this lock as some sort of a placeholder now.

Even, I'm not completely happy with this lock 🔒

Another better way to tackle this is to remove this lock parameter and display the first frame using chewie with a loading widget but in order to get the first frame, I think we the video player controller should be initialized first.

@ssaeed003
Copy link

Hello did you guys find a solution here? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⌛ Preload videos
3 participants