Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Story View Directionality Aware (Support RTL) #179

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

FirasAlShawa
Copy link

Hi Team,

This PR to support RTL and LTR as default.

Kindly let me know if you need further information.

Thanks!

@FirasAlShawa FirasAlShawa changed the title Make Story View Directionality Aware Make Story View Directionality Aware (Support RTL) Mar 31, 2024
@geekpius
Copy link
Collaborator

I can see you wish to change the entire items to support RTL. Why do need this? What's the use case? If you could elaborate more on this.

@FirasAlShawa
Copy link
Author

Hi @geekpius
Currently Story View support LTR which make since for the english apps, but if the default language of the app is RTL(like Arabic) the stories will animate from left to right which is not correct.

So I add the directionality of the story progress bars and animation.

Please let me know if you need a screen record.
Thank you!

@FirasAlShawa
Copy link
Author

Hi @geekpius ,

Please any update regarding my PR?

Thank you!

@geekpius
Copy link
Collaborator

geekpius commented Jul 3, 2024

Hi @geekpius ,

Please any update regarding my PR?

Thank you!

I will go through and get back to you if I have questions. If not it will be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants