Skip to content

Commit

Permalink
Cleanup and organize utils (#7033)
Browse files Browse the repository at this point in the history
* Force birdseye cameras into standard aspect ratios

* Organize utils

* Update tests

* Formatting

* Isort

* Fix tests

* Cleanup

* isort
  • Loading branch information
NickM-27 authored Jul 6, 2023
1 parent 606f008 commit baf671b
Show file tree
Hide file tree
Showing 29 changed files with 685 additions and 661 deletions.
2 changes: 1 addition & 1 deletion frigate/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
from frigate.storage import StorageMaintainer
from frigate.timeline import TimelineProcessor
from frigate.types import CameraMetricsTypes, FeatureMetricsTypes
from frigate.util import LimitedQueue as LQueue
from frigate.util.builtin import LimitedQueue as LQueue
from frigate.version import VERSION
from frigate.video import capture_camera, track_camera
from frigate.watchdog import FrigateWatchdog
Expand Down
2 changes: 1 addition & 1 deletion frigate/comms/dispatcher.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from frigate.config import FrigateConfig
from frigate.ptz import OnvifCommandEnum, OnvifController
from frigate.types import CameraMetricsTypes, FeatureMetricsTypes
from frigate.util import restart_frigate
from frigate.util.services import restart_frigate

logger = logging.getLogger(__name__)

Expand Down
4 changes: 2 additions & 2 deletions frigate/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,13 @@
parse_preset_output_rtmp,
)
from frigate.plus import PlusApi
from frigate.util import (
create_mask,
from frigate.util.builtin import (
deep_merge,
escape_special_characters,
get_ffmpeg_arg_list,
load_config_with_no_duplicates,
)
from frigate.util.image import create_mask

logger = logging.getLogger(__name__)

Expand Down
2 changes: 1 addition & 1 deletion frigate/detectors/detector_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
from pydantic.fields import PrivateAttr

from frigate.plus import PlusApi
from frigate.util import load_labels
from frigate.util.builtin import load_labels

logger = logging.getLogger(__name__)

Expand Down
3 changes: 2 additions & 1 deletion frigate/events/audio.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@
from frigate.log import LogPipe
from frigate.object_detection import load_labels
from frigate.types import FeatureMetricsTypes
from frigate.util import get_ffmpeg_arg_list, listen
from frigate.util.builtin import get_ffmpeg_arg_list
from frigate.util.services import listen
from frigate.video import start_or_restart_ffmpeg, stop_ffmpeg

try:
Expand Down
2 changes: 1 addition & 1 deletion frigate/events/external.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
from frigate.config import CameraConfig, FrigateConfig
from frigate.const import CLIPS_DIR
from frigate.events.maintainer import EventTypeEnum
from frigate.util import draw_box_with_label
from frigate.util.image import draw_box_with_label

logger = logging.getLogger(__name__)

Expand Down
2 changes: 1 addition & 1 deletion frigate/events/maintainer.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
from frigate.config import EventsConfig, FrigateConfig
from frigate.models import Event
from frigate.types import CameraMetricsTypes
from frigate.util import to_relative_box
from frigate.util.builtin import to_relative_box

logger = logging.getLogger(__name__)

Expand Down
2 changes: 1 addition & 1 deletion frigate/ffmpeg_presets.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from enum import Enum
from typing import Any

from frigate.util import vainfo_hwaccel
from frigate.util.services import vainfo_hwaccel
from frigate.version import VERSION

logger = logging.getLogger(__name__)
Expand Down
9 changes: 2 additions & 7 deletions frigate/http.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,8 @@
from frigate.record.export import PlaybackFactorEnum, RecordingExporter
from frigate.stats import stats_snapshot
from frigate.storage import StorageMaintainer
from frigate.util import (
clean_camera_user_pass,
ffprobe_stream,
get_tz_modifiers,
restart_frigate,
vainfo_hwaccel,
)
from frigate.util.builtin import clean_camera_user_pass, get_tz_modifiers
from frigate.util.services import ffprobe_stream, restart_frigate, vainfo_hwaccel
from frigate.version import VERSION

logger = logging.getLogger(__name__)
Expand Down
2 changes: 1 addition & 1 deletion frigate/log.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
from faster_fifo import Queue
from setproctitle import setproctitle

from frigate.util import clean_camera_user_pass
from frigate.util.builtin import clean_camera_user_pass


def listener_configurer() -> None:
Expand Down
4 changes: 3 additions & 1 deletion frigate/object_detection.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@

from frigate.detectors import create_detector
from frigate.detectors.detector_config import InputTensorEnum
from frigate.util import EventsPerSecond, SharedMemoryFrameManager, listen, load_labels
from frigate.util.builtin import EventsPerSecond, load_labels
from frigate.util.image import SharedMemoryFrameManager
from frigate.util.services import listen

logger = logging.getLogger(__name__)

Expand Down
2 changes: 1 addition & 1 deletion frigate/object_processing.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
)
from frigate.const import CLIPS_DIR
from frigate.events.maintainer import EventTypeEnum
from frigate.util import (
from frigate.util.image import (
SharedMemoryFrameManager,
area,
calculate_region,
Expand Down
6 changes: 5 additions & 1 deletion frigate/output.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,11 @@

from frigate.config import BirdseyeModeEnum, FrigateConfig
from frigate.const import BASE_DIR, BIRDSEYE_PIPE
from frigate.util import SharedMemoryFrameManager, copy_yuv_to_position, get_yuv_crop
from frigate.util.image import (
SharedMemoryFrameManager,
copy_yuv_to_position,
get_yuv_crop,
)

logger = logging.getLogger(__name__)

Expand Down
3 changes: 2 additions & 1 deletion frigate/record/maintainer.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
from frigate.const import CACHE_DIR, MAX_SEGMENT_DURATION, RECORD_DIR
from frigate.models import Event, Recordings
from frigate.types import FeatureMetricsTypes
from frigate.util import area, get_video_properties
from frigate.util.image import area
from frigate.util.services import get_video_properties

logger = logging.getLogger(__name__)

Expand Down
2 changes: 1 addition & 1 deletion frigate/record/record.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
from frigate.record.cleanup import RecordingCleanup
from frigate.record.maintainer import RecordingMaintainer
from frigate.types import FeatureMetricsTypes
from frigate.util import listen
from frigate.util.services import listen

logger = logging.getLogger(__name__)

Expand Down
2 changes: 1 addition & 1 deletion frigate/stats.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
from frigate.const import CACHE_DIR, CLIPS_DIR, DRIVER_AMD, DRIVER_ENV_VAR, RECORD_DIR
from frigate.object_detection import ObjectDetectProcess
from frigate.types import CameraMetricsTypes, StatsTrackingTypes
from frigate.util import (
from frigate.util.services import (
get_amd_gpu_stats,
get_bandwidth_stats,
get_cpu_stats,
Expand Down
2 changes: 1 addition & 1 deletion frigate/test/test_camera_pw.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import unittest

from frigate.util import clean_camera_user_pass, escape_special_characters
from frigate.util.builtin import clean_camera_user_pass, escape_special_characters


class TestUserPassCleanup(unittest.TestCase):
Expand Down
2 changes: 1 addition & 1 deletion frigate/test/test_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
from frigate.const import MODEL_CACHE_DIR
from frigate.detectors import DetectorTypeEnum
from frigate.plus import PlusApi
from frigate.util import deep_merge, load_config_with_no_duplicates
from frigate.util.builtin import deep_merge, load_config_with_no_duplicates


class TestConfig(unittest.TestCase):
Expand Down
2 changes: 1 addition & 1 deletion frigate/test/test_copy_yuv_to_position.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import cv2
import numpy as np

from frigate.util import copy_yuv_to_position, get_yuv_crop
from frigate.util.image import copy_yuv_to_position, get_yuv_crop


class TestCopyYuvToPosition(TestCase):
Expand Down
2 changes: 1 addition & 1 deletion frigate/test/test_gpu_stats.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import unittest
from unittest.mock import MagicMock, patch

from frigate.util import get_amd_gpu_stats, get_intel_gpu_stats
from frigate.util.services import get_amd_gpu_stats, get_intel_gpu_stats


class TestGpuStats(unittest.TestCase):
Expand Down
2 changes: 1 addition & 1 deletion frigate/test/test_video.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from norfair.drawing.color import Palette
from norfair.drawing.drawer import Drawer

from frigate.util import intersection
from frigate.util.image import intersection
from frigate.video import (
get_cluster_boundary,
get_cluster_candidates,
Expand Down
2 changes: 1 addition & 1 deletion frigate/test/test_yuv_region_2_rgb.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import cv2
import numpy as np

from frigate.util import yuv_region_2_rgb
from frigate.util.image import yuv_region_2_rgb


class TestYuvRegion2RGB(TestCase):
Expand Down
2 changes: 1 addition & 1 deletion frigate/timeline.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from frigate.config import FrigateConfig
from frigate.events.maintainer import EventTypeEnum
from frigate.models import Timeline
from frigate.util import to_relative_box
from frigate.util.builtin import to_relative_box

logger = logging.getLogger(__name__)

Expand Down
2 changes: 1 addition & 1 deletion frigate/track/norfair_tracker.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

from frigate.config import DetectConfig
from frigate.track import ObjectTracker
from frigate.util import intersection_over_union
from frigate.util.image import intersection_over_union


# Normalizes distance from estimate relative to object size
Expand Down
Loading

0 comments on commit baf671b

Please sign in to comment.