Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search fixes #14217

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Search fixes #14217

merged 2 commits into from
Oct 8, 2024

Conversation

hawkeye217
Copy link
Collaborator

@hawkeye217 hawkeye217 commented Oct 8, 2024

Proposed change

  • Ensure semantic search is enabled before checking model download state. Users without semantic search enabled would see an endless spinner on the Explore page.
  • Only clear similarity search filters when clicking the "x" in the Similarity Search pill. The old behavior cleared all the filters.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • The code has been formatted using Ruff (ruff format frigate)

Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for frigate-docs canceled.

Name Link
🔨 Latest commit 8df8637
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/67052967b42bfb00086b59c3

@hawkeye217 hawkeye217 changed the title Ensure semantic search is enabled before checking model download state Search fixes Oct 8, 2024
@NickM-27 NickM-27 merged commit d558ac8 into dev Oct 8, 2024
13 checks passed
@NickM-27 NickM-27 deleted the fix-search branch October 8, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants