Misc todos #217
Merged
Misc todos #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markuspluna
previously approved these changes
Mar 28, 2024
| @@ -51,10 +51,12 @@ impl UserBalance { | |||
| if self.shares < to_q { | |||
| panic_with_error!(e, BackstopError::BalanceError); | |||
| } | |||
| if self.q4w.len() >= MAX_Q4W_SIZE { | |||
There was a problem hiding this comment.
No particular reason - I kept it fairly restrictive as 10 means users are creating a new Q4W every 2 days before they can start withdrawing to create more (which seems excessive).
I can increase this if you feel it's too restrictive.
Resource wise, it could handle at least 50, but I'd need to perform some tests to ensure it's safe after that.
There was a problem hiding this comment.
We decided that increasing max_q4w_size to 21 (at most 1 entry a day for the 21 day lock period) felt more reasonable than this.
Commit was updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle various TODOs - mostly around resource concerns that were placed before we knew what the phase 2 limits would be.