SCLD-17783 Removes usage of deprecated draftjs props #3
+61
−101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SCLD-17783
Changes
onTab
,onUpArrow
, andonDownArrow
are all deprecated functions and cause very noisy console warnings in SCLDreact-draft-wysiwyg
exposes these props on theEditor
component, although we do not use them.keyBindingFn
to the draftjsEditor
. This function just checks for the 3 special cases, calls those functions, and then returns the default value for that key.getDefaultKeyBinding
does not have a value for tab, up, or down, so the behavior between the custom props and the default behavior are totally separate.Testing