SmartKeys with KB disabled

- Showing SmartKeys with the hardware keyboard has been working in a non-consistent way since the last iOS. We are disabling it as we kinda have to decide between having the keyboard bar properly hidden completely or this. And the keys were not useful on iPad anyway. We will figure out a better way for iOS18.
blinksh · Apr 8, 2024 · fb6a4bb · fb6a4bb
1 parent ac1f002
commit fb6a4bb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/Blink/KBTracker.swift b/Blink/KBTracker.swift
@@ -139,7 +139,8 @@ class KBObserver: NSObject, UIInteraction {
 }
 
 class KBTracker: NSObject {
-  private(set) var hideSmartKeysWithHKB = !BKUserConfigurationManager.userSettingsValue(forKey: BKUserConfigShowSmartKeysWithXKeyBoard)
+  private(set) var hideSmartKeysWithHKB = true
+  //private(set) var hideSmartKeysWithHKB = !BKUserConfigurationManager.userSettingsValue(forKey: BKUserConfigShowSmartKeysWithXKeyBoard)
 
   @objc static let shared = KBTracker()
 
@@ -229,7 +230,8 @@ class KBTracker: NSObject {
   }
 
   @objc private func _updateSettings() {
-    hideSmartKeysWithHKB = !BKUserConfigurationManager.userSettingsValue(forKey: BKUserConfigShowSmartKeysWithXKeyBoard)
+    hideSmartKeysWithHKB = true
+    //hideSmartKeysWithHKB = !BKUserConfigurationManager.userSettingsValue(forKey: BKUserConfigShowSmartKeysWithXKeyBoard)
 
     input?.sync(traits: kbTraits, device: kbDevice, hideSmartKeysWithHKB: hideSmartKeysWithHKB)
   }

diff --git a/Settings/Base.lproj/Settings.storyboard b/Settings/Base.lproj/Settings.storyboard
@@ -38,7 +38,7 @@
                         <sections>
                             <tableViewSection footerTitle="Note: on iPads, Smart Keys bar is visible only when Settings.app → General → Keyboard → Shortcuts toggle is on." id="4LL-aT-m70">
                                 <cells>
-                                    <tableViewCell clipsSubviews="YES" contentMode="scaleToFill" preservesSuperviewLayoutMargins="YES" selectionStyle="none" indentationWidth="10" rowHeight="44" id="Pas-GB-VuG">
+                                    <tableViewCell hidden="YES" clipsSubviews="YES" contentMode="scaleToFill" preservesSuperviewLayoutMargins="YES" selectionStyle="none" indentationWidth="10" rowHeight="44" id="Pas-GB-VuG">
                                         <rect key="frame" x="0.0" y="18" width="768" height="44"/>
                                         <autoresizingMask key="autoresizingMask"/>
                                         <tableViewCellContentView key="contentView" opaque="NO" clipsSubviews="YES" multipleTouchEnabled="YES" contentMode="center" preservesSuperviewLayoutMargins="YES" tableViewCell="Pas-GB-VuG" id="MJS-q5-cvs">