Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix left value not updating when scrolling horizontally with fixed position #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix left value not updating when scrolling horizontally with fixed position #23

wants to merge 1 commit into from

Conversation

dotdoubleyou
Copy link

I fixed two bugs that occur when you scroll horizontally:

  • When you have already scrolled to the right and you enter the VIEWPORT-BOTTOM affixType, the sidebar jumps to the right. (already worked correctly for VIEWPORT-TOP)
  • When scrolling horizontally in either the VIEWPORT-BOTTOM or VIEWPORT-TOP affixType, the sidebar stays fixed in one place.

You can see both bugs in this video:
https://user-images.githubusercontent.com/129282340/228540452-82836699-464c-4ba7-abcd-3439c87c4a1e.mp4

@AnnaDamm
Copy link

@blixhavn Could you take a look at this, please?

@pascalheidmann
Copy link

This PR is stalled? Or any chance for reviving the lib @blixhavn?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dotdoubleyou @AnnaDamm @pascalheidmann