Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a new mcp system + refactor to support it #552

Merged
merged 14 commits into from
Jan 8, 2025

Conversation

Kvadratni
Copy link
Collaborator

@Kvadratni Kvadratni commented Jan 7, 2025

This PR integrates goose with Jetbrains IDE's
For the system to work you have to have an open IDE and MCP plugin installed
https://plugins.jetbrains.com/plugin/26071-mcp-server

goose.IDE.mov

@Kvadratni Kvadratni marked this pull request as draft January 7, 2025 22:55
@Kvadratni Kvadratni force-pushed the mnovich/add-jetbrains-mcp branch 2 times, most recently from 2533514 to 534fedd Compare January 8, 2025 01:39
@salman1993 salman1993 requested a review from wendytang January 8, 2025 18:33
@Kvadratni Kvadratni force-pushed the mnovich/add-jetbrains-mcp branch from 60da8aa to 4e7fac4 Compare January 8, 2025 18:41
Copy link

github-actions bot commented Jan 8, 2025

Desktop App for this PR

The following build is available for testing:

The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder.

This link is provided by nightly.link and will work even if you're not logged into GitHub.

@Kvadratni Kvadratni marked this pull request as ready for review January 8, 2025 19:08
Copy link
Collaborator

@michaelneale michaelneale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super cool - only suggestion (pending some others) is should this be one that is added in on cli by user (for their setup) vs on all the time? (as only a portion of users use IJ so adds a bit to the prompts if I understand correctly)

crates/goose-cli/src/commands/mcp.rs Show resolved Hide resolved
crates/goose-cli/src/commands/session.rs Outdated Show resolved Hide resolved
crates/goose/src/agents/capabilities.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@wendytang wendytang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! do we want to turn the jetbrains server on by default?

@Kvadratni
Copy link
Collaborator Author

we don't but the adding dynamically flow is not great, so I did add it for test purposes

@Kvadratni Kvadratni force-pushed the mnovich/add-jetbrains-mcp branch from 8f39941 to ad08660 Compare January 8, 2025 22:30
Copy link

github-actions bot commented Jan 8, 2025

Desktop App for this PR

The following build is available for testing:

The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder.

This link is provided by nightly.link and will work even if you're not logged into GitHub.

@Kvadratni Kvadratni merged commit cbbb253 into v1.0 Jan 8, 2025
6 checks passed
michaelneale added a commit that referenced this pull request Jan 9, 2025
* v1.0:
  feat: Implement a simplified reference agent and dev toolkit (#564)
  fix: sanitize server names for passing into model tool calls (#563)
  added a new mcp system + refactor to support it (#552)
  feat: port over nondeveloper system into mcp server (#561)
  fix: check server capability when client sends requests (#558)
  fix: update instructions (#557)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants