Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support generic Routers in mcp runners #553

Closed
wants to merge 2 commits into from
Closed

Conversation

baxen
Copy link
Collaborator

@baxen baxen commented Jan 7, 2025

Introduces a trait alias to make that easier across the code base too

Introduces a trait alias to make that easier across the code base too
Copy link

github-actions bot commented Jan 7, 2025

Desktop App for this PR

The following build is available for testing:

The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder.

This link is provided by nightly.link and will work even if you're not logged into GitHub.


// Define a specific service implementation that we need for any
// Any router implements this
pub trait BoundedService:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a more obvious name? (I assume this is fine, but not sure what it does without looking further?)

@michaelneale
Copy link
Collaborator

@Kvadratni I believe you pulled this in to your branch?

@michaelneale
Copy link
Collaborator

@baxen I think these were added by other branches

Copy link

github-actions bot commented Jan 9, 2025

Desktop App for this PR

The following build is available for testing:

The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder.

This link is provided by nightly.link and will work even if you're not logged into GitHub.

@baxen baxen closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants