Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poc/base64 video #1392

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Poc/base64 video #1392

wants to merge 8 commits into from

Conversation

lemoustachiste
Copy link
Member

Add basic support for base64 mp4 videos.
Confirmed videos also work with hashlinks.

Missing tests.

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2023

Codecov Report

Base: 66.67% // Head: 66.67% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (7082c41) compared to base (f3baedb).
Patch coverage: 77.77% of modified lines in pull request are covered.

❗ Current head 7082c41 differs from pull request most recent head 089d942. Consider uploading reports for the commit 089d942 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1392      +/-   ##
==========================================
- Coverage   66.67%   66.67%   -0.01%     
==========================================
  Files         179      179              
  Lines        3388     3394       +6     
  Branches      760      761       +1     
==========================================
+ Hits         2259     2263       +4     
- Misses        959      961       +2     
  Partials      170      170              
Impacted Files Coverage Δ
src/selectors/certificate.ts 85.18% <60.00%> (-0.84%) ⬇️
src/constants/contentTypes.ts 100.00% <100.00%> (ø)
src/helpers/base64.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants