This repository has been archived by the owner on Mar 7, 2023. It is now read-only.
Dgld #2
Closed
Dgld #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 🔧 update FIO block explorer url * update coins.md
Makefiles fixed. Unit tests passing.
* update zcash/xlm block explorer * Fix tests
* support IoTeX native staking
Add missing call to `delete` in function `fileR`.
* Script for building sample app (C++). * Include go sample app in build script. * Add echo's. * Sample build: include OSX and Android build. * Minor FIo test extension. * Samples build: split in 3, by 3 build platforms. * Revert "Samples build: split in 3, by 3 build platforms." This reverts commit a262043. * Options for different platforms. * Sample-build: Rearranged with functions per sample app Co-authored-by: Catenocrypt <[email protected]>
* Create CODEOWNERS
* Create android-ci.yml * Add ios-ci.yml * Add linux-ci.yml * Add sudo * try set boost version * install libc++ * Fix linux coverage * move internal src to local/src * Fix protobuf symbolic link
* Bitcoin Script minor fixes and new tests. * Extra tests for the missing 3 lines. * Fix isPayToWitnessScriptHash (was typo), new isPayToWitnessPublicKeyHash(). * A rename (Pubkey -> PublicKey). * Extra test for TWBitcoinScript coverage.
Package version updates.
* Some low-impact cppcheck finding fixes. * Some reverts to address diff coverage metric. * Add scripts for cppcheck to tools. * Some minor reference type style linting. Co-authored-by: Catenocrypt <[email protected]>
* Registers new coin. * Define protobuf models * Implement entry, address and add tests * Fix AnyAddress, add further address tests * Implement serialization and signing, add tests * Add key derivation tests * Add tests for Android * Add tests for iOS * Fix derivation path and tests * Fix after review (including build issues)
pavel-bc
reviewed
May 1, 2020
| val address = AnyAddress(pubkey, CoinType.DIGITALGOLD) | ||
| val expected = AnyAddress("__EXPECTED_RESULT_ADDRESS__", CoinType.DIGITALGOLD) | ||
|
|
||
| assertEquals(pubkey.data().toHex(), "0x__EXPECTED_PUBKEY_DATA__") |
There was a problem hiding this comment.
@haael This is unclear - are you planning to follow-up in this or next PR with actual test cases?
| set(protobuf_SOURCE_DIR ${CMAKE_SOURCE_DIR}/wallet-core/build/protobuf/staging/protobuf-3.9.0) | ||
| set(protobuf_source_dir ${CMAKE_SOURCE_DIR}/wallet-core/build/protobuf/staging/protobuf-3.9.0) | ||
| set(protobuf_SOURCE_DIR ${CMAKE_SOURCE_DIR}/build/local/src/protobuf/protobuf-3.9.0) | ||
| set(protobuf_source_dir ${CMAKE_SOURCE_DIR}/build/local/src/protobuf/protobuf-3.9.0) |
There was a problem hiding this comment.
We will need to rollback this before merging, otherwise, the submodule setup will break. In future, we need to make it configurable
|
|
||
| @Test | ||
| fun DigitalGoldTransactionSigning() { | ||
| // TODO: Finalize implementation |
| let key = PrivateKey(data: Data(hexString: "__PRIVATE_KEY_DATA__")!)! | ||
| let pubkey = key.getPublicKeyEd25519() | ||
| let address = AnyAddress(publicKey: pubkey, coin: .digitalgold) | ||
| let addressFromString = AnyAddress(string: "__ADDRESS_DATA__", coin: .digitalgold)! |
| //auto result = transaction.serialize(signature); | ||
|
|
||
| //ASSERT_EQ(hex(serialized), "__RESULT__"); | ||
| //ASSERT_EQ(...) |
|
Closing in favor of #3 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementation of DGLD coin.
Testing instructions
C++: Tests will be executed after build.
Android: Build the project in 'android' dir, run on device.