Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FoxWallet support #1994

Closed
wants to merge 1 commit into from

Conversation

icodeface
Copy link
Contributor

Description

This PR adds FoxWallet as a supported wallet.

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

Docs Checklist

  • Include a screenshot of any changes (see docs README on running locally)
  • Add/update the appropriate package README (if applicable)
  • Add/update the related module in the docs demo (if applicable)
  • Add/update the related package in the docs/package.json file (if applicable)

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Tests with demo app (SDK)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

@Adamj1232
Copy link
Member

@icodeface thanks for opening the PR! Unfortunately we will not be able to support this update to create a fox-wallet module.
As fox-wallet is an injected-wallet with no SDK requirements all functionality can be added to web3-onboard through adding fox wallet to the injected module.
We discontinued accepting new module that add support for injected wallets and dont have an SDK requirement as each module greatly increases dev time in support and all functionality can be found through add your wallet to the injected wallets module.
And example of this can be found here - https://github.com/blocknative/web3-onboard/pull/1177/files
If you would like to make this update and create a new PR or just update this PR that would be great!
Injected Wallet Contribution Guide: https://onboard.blocknative.com/docs/overview/contribution-guide#adding-injected-wallets

@icodeface
Copy link
Contributor Author

@icodeface thanks for opening the PR! Unfortunately we will not be able to support this update to create a fox-wallet module. As fox-wallet is an injected-wallet with no SDK requirements all functionality can be added to web3-onboard through adding fox wallet to the injected module. We discontinued accepting new module that add support for injected wallets and dont have an SDK requirement as each module greatly increases dev time in support and all functionality can be found through add your wallet to the injected wallets module. And example of this can be found here - https://github.com/blocknative/web3-onboard/pull/1177/files If you would like to make this update and create a new PR or just update this PR that would be great! Injected Wallet Contribution Guide: https://onboard.blocknative.com/docs/overview/contribution-guide#adding-injected-wallets

Thanks, provided a new PR #1997

@icodeface icodeface closed this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants