Skip to content

Commit

Permalink
build: Simplify mkfatimg invocation
Browse files Browse the repository at this point in the history
Since commit 2f28cf8 ("Fix segmentation fault") mkfatimg supports
invoking it without specifying a filesystem image size in the command
line. Until the, it was required to specify 0 as size to autocalculate
the size.

This commit removes all now unneeded zeroes from the makefiles where
mkfatimg is invoked.
  • Loading branch information
AntonioND committed Jul 26, 2023
1 parent 7e8c884 commit 41b479b
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 12 deletions.
4 changes: 2 additions & 2 deletions examples/libxm7/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ NDSTOOL_FAT := -F $(NITROFAT_IMG)

$(NITROFAT_IMG): $(NITROFATDIR)
@echo " MKFATIMG $@ $(NITROFATDIR)"
$(V)$(BLOCKSDS)/tools/mkfatimg/mkfatimg -t $(NITROFATDIR) $@ 0
$(V)$(BLOCKSDS)/tools/mkfatimg/mkfatimg -t $(NITROFATDIR) $@

# Make the NDS ROM depend on the filesystem image only if it is needed
$(ROM): $(NITROFAT_IMG)
Expand All @@ -102,7 +102,7 @@ $(ROM): arm9 arm7

sdimage:
@echo " MKFATIMG $(SDIMAGE) $(SDROOT)"
$(V)$(BLOCKSDS)/tools/mkfatimg/mkfatimg -t $(SDROOT) $(SDIMAGE) 0
$(V)$(BLOCKSDS)/tools/mkfatimg/mkfatimg -t $(SDROOT) $(SDIMAGE)

dldipatch: $(ROM)
@echo " DLDITOOL $(ROM)"
Expand Down
4 changes: 2 additions & 2 deletions examples/nocash_debug/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ NDSTOOL_FAT := -F $(NITROFAT_IMG)

$(NITROFAT_IMG): $(NITROFATDIR)
@echo " MKFATIMG $@ $(NITROFATDIR)"
$(V)$(BLOCKSDS)/tools/mkfatimg/mkfatimg -t $(NITROFATDIR) $@ 0
$(V)$(BLOCKSDS)/tools/mkfatimg/mkfatimg -t $(NITROFATDIR) $@

# Make the NDS ROM depend on the filesystem image only if it is needed
$(ROM): $(NITROFAT_IMG)
Expand All @@ -102,7 +102,7 @@ $(ROM): arm9 arm7

sdimage:
@echo " MKFATIMG $(SDIMAGE) $(SDROOT)"
$(V)$(BLOCKSDS)/tools/mkfatimg/mkfatimg -t $(SDROOT) $(SDIMAGE) 0
$(V)$(BLOCKSDS)/tools/mkfatimg/mkfatimg -t $(SDROOT) $(SDIMAGE)

dldipatch: $(ROM)
@echo " DLDITOOL $(ROM)"
Expand Down
4 changes: 2 additions & 2 deletions templates/rom_arm9_only/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ NDSTOOL_FAT := -F $(NITROFAT_IMG)

$(NITROFAT_IMG): $(NITROFATDIR)
@echo " MKFATIMG $@ $(NITROFATDIR)"
$(V)$(BLOCKSDS)/tools/mkfatimg/mkfatimg -t $(NITROFATDIR) $@ 0
$(V)$(BLOCKSDS)/tools/mkfatimg/mkfatimg -t $(NITROFATDIR) $@

# Make the NDS ROM depend on the filesystem image only if it is needed
$(ROM): $(NITROFAT_IMG)
Expand Down Expand Up @@ -222,7 +222,7 @@ clean:

sdimage:
@echo " MKFATIMG $(SDIMAGE) $(SDROOT)"
$(V)$(BLOCKSDS)/tools/mkfatimg/mkfatimg -t $(SDROOT) $(SDIMAGE) 0
$(V)$(BLOCKSDS)/tools/mkfatimg/mkfatimg -t $(SDROOT) $(SDIMAGE)

dldipatch: $(ROM)
@echo " DLDITOOL $(ROM)"
Expand Down
4 changes: 2 additions & 2 deletions templates/rom_combined/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ NDSTOOL_FAT := -F $(NITROFAT_IMG)

$(NITROFAT_IMG): $(NITROFATDIR)
@echo " MKFATIMG $@ $(NITROFATDIR)"
$(V)$(BLOCKSDS)/tools/mkfatimg/mkfatimg -t $(NITROFATDIR) $@ 0
$(V)$(BLOCKSDS)/tools/mkfatimg/mkfatimg -t $(NITROFATDIR) $@

# Make the NDS ROM depend on the filesystem image only if it is needed
$(ROM): $(NITROFAT_IMG)
Expand All @@ -102,7 +102,7 @@ $(ROM): arm9 arm7

sdimage:
@echo " MKFATIMG $(SDIMAGE) $(SDROOT)"
$(V)$(BLOCKSDS)/tools/mkfatimg/mkfatimg -t $(SDROOT) $(SDIMAGE) 0
$(V)$(BLOCKSDS)/tools/mkfatimg/mkfatimg -t $(SDROOT) $(SDIMAGE)

dldipatch: $(ROM)
@echo " DLDITOOL $(ROM)"
Expand Down
4 changes: 2 additions & 2 deletions tests/Makefile.include
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ NDSTOOL_FAT := -F $(NITROFAT_IMG)

$(NITROFAT_IMG): $(NITROFATDIR)
@echo " MKFATIMG $@ $(NITROFATDIR)"
$(V)$(BLOCKSDS)/tools/mkfatimg/mkfatimg -t $(NITROFATDIR) $@ 0
$(V)$(BLOCKSDS)/tools/mkfatimg/mkfatimg -t $(NITROFATDIR) $@

# Make the NDS ROM depend on the filesystem image only if it is needed
$(ROM): $(NITROFAT_IMG)
Expand Down Expand Up @@ -203,7 +203,7 @@ clean:

sdimage:
@echo " MKFATIMG $(SDIMAGE) $(SDROOT)"
$(V)$(BLOCKSDS)/tools/mkfatimg/mkfatimg -t $(SDROOT) $(SDIMAGE) 0
$(V)$(BLOCKSDS)/tools/mkfatimg/mkfatimg -t $(SDROOT) $(SDIMAGE)

dldipatch: $(ROM)
@echo " DLDITOOL $(ROM)"
Expand Down
4 changes: 2 additions & 2 deletions tests/fifo_stress_test/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ NDSTOOL_FAT := -F $(NITROFAT_IMG)

$(NITROFAT_IMG): $(NITROFATDIR)
@echo " MKFATIMG $@ $(NITROFATDIR)"
$(V)$(BLOCKSDS)/tools/mkfatimg/mkfatimg -t $(NITROFATDIR) $@ 0
$(V)$(BLOCKSDS)/tools/mkfatimg/mkfatimg -t $(NITROFATDIR) $@

# Make the NDS ROM depend on the filesystem image only if it is needed
$(ROM): $(NITROFAT_IMG)
Expand All @@ -102,7 +102,7 @@ $(ROM): arm9 arm7

sdimage:
@echo " MKFATIMG $(SDIMAGE) $(SDROOT)"
$(V)$(BLOCKSDS)/tools/mkfatimg/mkfatimg -t $(SDROOT) $(SDIMAGE) 0
$(V)$(BLOCKSDS)/tools/mkfatimg/mkfatimg -t $(SDROOT) $(SDIMAGE)

dldipatch: $(ROM)
@echo " DLDITOOL $(ROM)"
Expand Down

0 comments on commit 41b479b

Please sign in to comment.