Refine

Signed-off-by: Evgeny Malygin <[email protected]>
bloomberg · Dec 6, 2024 · 41b20a9 · 41b20a9
1 parent 9789a59
commit 41b20a9
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 15 deletions.
diff --git a/src/groups/mqb/mqbblp/mqbblp_storagemanager.cpp b/src/groups/mqb/mqbblp/mqbblp_storagemanager.cpp
@@ -1334,8 +1334,8 @@ int StorageManager::start(bsl::ostream& errorDescription)
         d_clusterConfig.partitionConfig();
 
     // Validate file size limits before checking the available disk space
-    if (partitionCfg.maxDataFileSize() >
-        mqbs::FileStoreProtocol::k_MAX_DATA_FILE_SIZE_HARD) {
+    if (mqbs::FileStoreProtocol::k_MAX_DATA_FILE_SIZE_HARD <
+        partitionCfg.maxDataFileSize()) {
         BALL_LOG_ERROR << "Configured maxDataFileSize ("
                        << partitionCfg.maxDataFileSize()
                        << ") exceeds the protocol limit ("
@@ -1344,8 +1344,8 @@ int StorageManager::start(bsl::ostream& errorDescription)
         return rc_OVERFLOW_MAX_DATA_FILE_SIZE;
     }
 
-    if (partitionCfg.maxJournalFileSize() >
-        mqbs::FileStoreProtocol::k_MAX_JOURNAL_FILE_SIZE_HARD) {
+    if (mqbs::FileStoreProtocol::k_MAX_JOURNAL_FILE_SIZE_HARD <
+        partitionCfg.maxJournalFileSize()) {
         BALL_LOG_ERROR << "Configured maxJournalFileSize ("
                        << partitionCfg.maxJournalFileSize()
                        << ") exceeds the protocol limit ("
@@ -1354,8 +1354,8 @@ int StorageManager::start(bsl::ostream& errorDescription)
         return rc_OVERFLOW_MAX_JOURNAL_FILE_SIZE;
     }
 
-    if (partitionCfg.maxQlistFileSize() >
-        mqbs::FileStoreProtocol::k_MAX_QLIST_FILE_SIZE_HARD) {
+    if (mqbs::FileStoreProtocol::k_MAX_QLIST_FILE_SIZE_HARD <
+        partitionCfg.maxQlistFileSize()) {
         BALL_LOG_ERROR << "Configured maxQlistFileSize ("
                        << partitionCfg.maxQlistFileSize()
                        << ") exceeds the protocol limit ("

diff --git a/src/groups/mqb/mqbc/mqbc_storagemanager.cpp b/src/groups/mqb/mqbc/mqbc_storagemanager.cpp
@@ -3480,8 +3480,8 @@ int StorageManager::start(bsl::ostream& errorDescription)
         d_clusterConfig.partitionConfig();
 
     // Validate file size limits before checking the available disk space
-    if (partitionCfg.maxDataFileSize() >
-        mqbs::FileStoreProtocol::k_MAX_DATA_FILE_SIZE_HARD) {
+    if (mqbs::FileStoreProtocol::k_MAX_DATA_FILE_SIZE_HARD <
+        partitionCfg.maxDataFileSize()) {
         BALL_LOG_ERROR << "Configured maxDataFileSize ("
                        << partitionCfg.maxDataFileSize()
                        << ") exceeds the protocol limit ("
@@ -3490,8 +3490,8 @@ int StorageManager::start(bsl::ostream& errorDescription)
         return rc_OVERFLOW_MAX_DATA_FILE_SIZE;
     }
 
-    if (partitionCfg.maxJournalFileSize() >
-        mqbs::FileStoreProtocol::k_MAX_JOURNAL_FILE_SIZE_HARD) {
+    if (mqbs::FileStoreProtocol::k_MAX_JOURNAL_FILE_SIZE_HARD <
+        partitionCfg.maxJournalFileSize()) {
         BALL_LOG_ERROR << "Configured maxJournalFileSize ("
                        << partitionCfg.maxJournalFileSize()
                        << ") exceeds the protocol limit ("
@@ -3500,8 +3500,8 @@ int StorageManager::start(bsl::ostream& errorDescription)
         return rc_OVERFLOW_MAX_JOURNAL_FILE_SIZE;
     }
 
-    if (partitionCfg.maxQlistFileSize() >
-        mqbs::FileStoreProtocol::k_MAX_QLIST_FILE_SIZE_HARD) {
+    if (mqbs::FileStoreProtocol::k_MAX_QLIST_FILE_SIZE_HARD <
+        partitionCfg.maxQlistFileSize()) {
         BALL_LOG_ERROR << "Configured maxQlistFileSize ("
                        << partitionCfg.maxQlistFileSize()
                        << ") exceeds the protocol limit ("

diff --git a/src/groups/mqb/mqbs/mqbs_filestoreprotocol.h b/src/groups/mqb/mqbs/mqbs_filestoreprotocol.h
@@ -60,13 +60,13 @@
 //       Max QlistFileHeader size.......................: 1020 bytes
 //       Max QueueRecordHeader size.....................: 1020 bytes
 //       Max Data file size.............................: 34359738360 bytes
-//                                                        or 32GB - 8B
+//                                                        or 32GiB - 8B
 //               (See also: mqbs::FileStoreProtocol::k_MAX_DATA_FILE_SIZE_HARD)
 //       Max Journal file size..........................: 17179869180 bytes
-//                                                        or 16GB - 8B
+//                                                        or 16GiB - 8B
 //            (See also: mqbs::FileStoreProtocol::k_MAX_JOURNAL_FILE_SIZE_HARD)
 //       Max Qlist file size............................: 17179869180 bytes
-//                                                        or 16GB - 8B
+//                                                        or 16GiB - 8B
 //              (See also: mqbs::FileStoreProtocol::k_MAX_QLIST_FILE_SIZE_HARD)
 //       Max Journal Record size........................: 1020 bytes
 //       Max Journal Record types.......................: 15