Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build ntf-core without -Werror #171

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

pniedzielski
Copy link
Collaborator

Occasional changes to ntf-core result in build errors, because we build ntf-core with warnings as errors. This patch copies the relevant changes from the Python SDK repository to avoid this, as well as to build fewer unnecessary parts of ntf-core.

Occasional changes to ntf-core result in build errors, because we build
ntf-core with warnings as errors.  This patch copies the relevant changes from
the Python SDK repository to avoid this, as well as to build fewer unnecessary
parts of ntf-core.

Signed-off-by: Patrick M. Niedzielski <[email protected]>
@pniedzielski pniedzielski added bug Something isn't working A-Build Area: Build System labels Dec 13, 2023
@pniedzielski pniedzielski requested a review from jll63 December 13, 2023 18:02
@pniedzielski pniedzielski requested a review from a team as a code owner December 13, 2023 18:02
@pniedzielski pniedzielski merged commit 94a5277 into bloomberg:main Jan 3, 2024
9 checks passed
@pniedzielski pniedzielski deleted the build-ntf-without-werror branch April 15, 2024 14:08
@pniedzielski pniedzielski restored the build-ntf-without-werror branch April 15, 2024 14:08
@pniedzielski pniedzielski deleted the build-ntf-without-werror branch May 1, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Build Area: Build System bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants