Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: update docker ubuntu version 22.04 -> 24.04 #333

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

678098
Copy link
Collaborator

@678098 678098 commented Jun 24, 2024

  • Restore the ability to build the docker image on MacOS
  • Ubuntu version 22.04 -> 24.04
  • Remove custom CMake installation, use the system one instead
  • addgroup -> groupadd, adduser -> useradd

@678098 678098 requested a review from a team as a code owner June 24, 2024 12:27
@678098 678098 force-pushed the i332_Mac_docker_build branch 10 times, most recently from 5a21a0d to f2a472d Compare June 24, 2024 13:08
@678098 678098 force-pushed the i332_Mac_docker_build branch from f2a472d to 9edb152 Compare June 24, 2024 16:15
@678098 678098 requested a review from pniedzielski June 24, 2024 17:11
@678098
Copy link
Collaborator Author

678098 commented Jun 24, 2024

#332

curl \
python3.10 \
python3 \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 3.10 -> Python 3.12

This is a change we want, though there's still some code we need to test as far back as 3.8. Let's keep this change; I think @jll63 and I need to coordinate on the 3.8 tests.

@@ -18,14 +19,6 @@ RUN apt-get update && \
&& apt clean \
&& rm -rf /var/lib/apt/lists/*

# BDE build requires CMake > 3.24, which is not available in Ubuntu 22.04 yet
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

Copy link
Collaborator

@hallfox hallfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@678098 678098 merged commit 1387dfa into bloomberg:main Jun 24, 2024
23 checks passed
@678098 678098 deleted the i332_Mac_docker_build branch June 24, 2024 19:52
lukedigiovanna pushed a commit to lukedigiovanna/blazingmq that referenced this pull request Jul 2, 2024
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants