-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Rename gtest conflicting test macros #535
Conversation
@hallfox DCO check failure and formatting check failure. Could you do the clang formatting fixes in another commit, so I can still easily review the first commit? |
61068ff
to
feac33c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build 393 of commit feac33c has completed with FAILURE
4b24bce
to
73e2eda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I see three remaining ASSERT
s outside of bmqst
; they don't prevent building but here they are:
src/groups/bmq/bmqp/bmqp_puteventbuilder.t.cpp
2281: ASSERT(rawEvent.isValid());
2282: ASSERT(rawEvent.isPutEvent());
2288: ASSERT(putIter.isValid());
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build 395 of commit 73e2eda has completed with FAILURE
6548a47
to
e7eef53
Compare
bmqtst provides several gtest-like compatibility macros, but this prevents us from using gtest or gmock directly because it uses the exact same names as the test macros from that library. Since we want to support at least using gmock in our tests, we rename them to avoid conflict. Signed-off-by: Taylor Foxhall <[email protected]>
e7eef53
to
e262c9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build 403 of commit e262c9f has completed with FAILURE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
bmqtst provides several gtest-like compatibility macros, but this prevents us from using gtest or gmock directly because it uses the exact same names as the test macros from that library. Since we want to support at least using gmock in our tests, we rename them to avoid conflict.